Core dumped while using vector
up vote
-4
down vote
favorite
So on Ubuntu I always get core dumped when trying to execute this function:
vector<string> inArray(vector<string> &array1, vector<string> &array2)
vector<string> result;
for(int i=0;i<array1.size();i++)
for(int j=0;j<array2.size();j++)
if(array1[i] == array2[j])result.push_back(array1[i]);
return result;
Can someone tell me what is wrong?
EDIT:
int main()
vector<string> arr1"arp", "live", "strong";
vector<string> arr2"lively", "alive", "harp", "sharp", "armstrong";
vector<string> result = inArray(arr1, arr2);
cout<<result[0];
cout<<result[1];
cout<<result[2];
return 0;
I was doing Kata on codewars.
c++ vector
edited Nov 10 at 12:50
Matteo Italia
97.3k13136236
asked Nov 10 at 11:55
qmwnebrv
112
|
show 4 more comments
up vote
-4
down vote
favorite
So on Ubuntu I always get core dumped when trying to execute this function:
vector<string> inArray(vector<string> &array1, vector<string> &array2)
vector<string> result;
for(int i=0;i<array1.size();i++)
for(int j=0;j<array2.size();j++)
if(array1[i] == array2[j])result.push_back(array1[i]);
return result;
Can someone tell me what is wrong?
EDIT:
int main()
vector<string> arr1"arp", "live", "strong";
vector<string> arr2"lively", "alive", "harp", "sharp", "armstrong";
vector<string> result = inArray(arr1, arr2);
cout<<result[0];
cout<<result[1];
cout<<result[2];
return 0;
I was doing Kata on codewars.
c++ vector
edited Nov 10 at 12:50
Matteo Italia
97.3k13136236
asked Nov 10 at 11:55
qmwnebrv
112
4
How is this function called?
– tkausl
Nov 10 at 11:58
What does your debugger say?
– melpomene
Nov 10 at 12:10
Welcome to SO, and congratulations on your first question. You may notice your question has been downvoted a few times, as it is not quite of the quality that gets great answers on here. You may find this guide helpful stackoverflow.com/help/how-to-ask.
– Tim Ogilvy
Nov 10 at 12:15
1
There's nothing obviously wrong with that, so the problem is probably in the surrounding code. Perhaps you're passing invalid vectors to it. You need to show how you're using the function. Read about what a Minimal, Complete, and Verifiable example is.
– molbdnilo
Nov 10 at 12:27
3
In this case an empty vector is returned. It probably crashes after the function returns, when you try to applyto it.
– HolyBlackCat
Nov 10 at 12:48
|
show 4 more comments
up vote
-4
down vote
favorite
up vote
-4
down vote
favorite
So on Ubuntu I always get core dumped when trying to execute this function:
vector<string> inArray(vector<string> &array1, vector<string> &array2)
vector<string> result;
for(int i=0;i<array1.size();i++)
for(int j=0;j<array2.size();j++)
if(array1[i] == array2[j])result.push_back(array1[i]);
return result;
Can someone tell me what is wrong?
EDIT:
int main()
vector<string> arr1"arp", "live", "strong";
vector<string> arr2"lively", "alive", "harp", "sharp", "armstrong";
vector<string> result = inArray(arr1, arr2);
cout<<result[0];
cout<<result[1];
cout<<result[2];
return 0;
I was doing Kata on codewars.
c++ vector
edited Nov 10 at 12:50
Matteo Italia
97.3k13136236
asked Nov 10 at 11:55
qmwnebrv
112
So on Ubuntu I always get core dumped when trying to execute this function:
vector<string> inArray(vector<string> &array1, vector<string> &array2)
vector<string> result;
for(int i=0;i<array1.size();i++)
for(int j=0;j<array2.size();j++)
if(array1[i] == array2[j])result.push_back(array1[i]);
return result;
Can someone tell me what is wrong?
EDIT:
int main()
vector<string> arr1"arp", "live", "strong";
vector<string> arr2"lively", "alive", "harp", "sharp", "armstrong";
vector<string> result = inArray(arr1, arr2);
cout<<result[0];
cout<<result[1];
cout<<result[2];
return 0;
I was doing Kata on codewars.
c++ vector
c++ vector
edited Nov 10 at 12:50
Matteo Italia
97.3k13136236
asked Nov 10 at 11:55
qmwnebrv
112
edited Nov 10 at 12:50
Matteo Italia
97.3k13136236
asked Nov 10 at 11:55
qmwnebrv
112
edited Nov 10 at 12:50
Matteo Italia
97.3k13136236
edited Nov 10 at 12:50
Matteo Italia
97.3k13136236
edited Nov 10 at 12:50
Matteo Italia
97.3k13136236
97.3k13136236
asked Nov 10 at 11:55
qmwnebrv
112
asked Nov 10 at 11:55
qmwnebrv
112
asked Nov 10 at 11:55
qmwnebrv
112
112
4
How is this function called?
– tkausl
Nov 10 at 11:58
What does your debugger say?
– melpomene
Nov 10 at 12:10
Welcome to SO, and congratulations on your first question. You may notice your question has been downvoted a few times, as it is not quite of the quality that gets great answers on here. You may find this guide helpful stackoverflow.com/help/how-to-ask.
– Tim Ogilvy
Nov 10 at 12:15
1
There's nothing obviously wrong with that, so the problem is probably in the surrounding code. Perhaps you're passing invalid vectors to it. You need to show how you're using the function. Read about what a Minimal, Complete, and Verifiable example is.
– molbdnilo
Nov 10 at 12:27
3
In this case an empty vector is returned. It probably crashes after the function returns, when you try to applyto it.
– HolyBlackCat
Nov 10 at 12:48
|
show 4 more comments
4
How is this function called?
– tkausl
Nov 10 at 11:58
What does your debugger say?
– melpomene
Nov 10 at 12:10
Welcome to SO, and congratulations on your first question. You may notice your question has been downvoted a few times, as it is not quite of the quality that gets great answers on here. You may find this guide helpful stackoverflow.com/help/how-to-ask.
– Tim Ogilvy
Nov 10 at 12:15
1
There's nothing obviously wrong with that, so the problem is probably in the surrounding code. Perhaps you're passing invalid vectors to it. You need to show how you're using the function. Read about what a Minimal, Complete, and Verifiable example is.
– molbdnilo
Nov 10 at 12:27
3
In this case an empty vector is returned. It probably crashes after the function returns, when you try to applyto it.
– HolyBlackCat
Nov 10 at 12:48
4
4
How is this function called?
– tkausl
Nov 10 at 11:58
How is this function called?
– tkausl
Nov 10 at 11:58
What does your debugger say?
– melpomene
Nov 10 at 12:10
What does your debugger say?
– melpomene
Nov 10 at 12:10
Welcome to SO, and congratulations on your first question. You may notice your question has been downvoted a few times, as it is not quite of the quality that gets great answers on here. You may find this guide helpful stackoverflow.com/help/how-to-ask.
– Tim Ogilvy
Nov 10 at 12:15
Welcome to SO, and congratulations on your first question. You may notice your question has been downvoted a few times, as it is not quite of the quality that gets great answers on here. You may find this guide helpful stackoverflow.com/help/how-to-ask.
– Tim Ogilvy
Nov 10 at 12:15
1
1
There's nothing obviously wrong with that, so the problem is probably in the surrounding code. Perhaps you're passing invalid vectors to it. You need to show how you're using the function. Read about what a Minimal, Complete, and Verifiable example is.
– molbdnilo
Nov 10 at 12:27
There's nothing obviously wrong with that, so the problem is probably in the surrounding code. Perhaps you're passing invalid vectors to it. You need to show how you're using the function. Read about what a Minimal, Complete, and Verifiable example is.
– molbdnilo
Nov 10 at 12:27
3
3
In this case an empty vector is returned. It probably crashes after the function returns, when you try to apply
– HolyBlackCat
Nov 10 at 12:48
In this case an empty vector is returned. It probably crashes after the function returns, when you try to apply
– HolyBlackCat
Nov 10 at 12:48
|
show 4 more comments
1 Answer
1
active
oldest
votes
up vote
0
down vote
accepted
Instead of printing result[0],result[1],result[2],first check the size of vector result and if it is '0' then return 0 or whatever is given and otherwise return result vector.
answered Nov 10 at 13:10
code_cody97
749
add a comment |
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
up vote
0
down vote
accepted
Instead of printing result[0],result[1],result[2],first check the size of vector result and if it is '0' then return 0 or whatever is given and otherwise return result vector.
answered Nov 10 at 13:10
code_cody97
749
add a comment |
up vote
0
down vote
accepted
Instead of printing result[0],result[1],result[2],first check the size of vector result and if it is '0' then return 0 or whatever is given and otherwise return result vector.
answered Nov 10 at 13:10
code_cody97
749
add a comment |
up vote
0
down vote
accepted
up vote
0
down vote
accepted
Instead of printing result[0],result[1],result[2],first check the size of vector result and if it is '0' then return 0 or whatever is given and otherwise return result vector.
answered Nov 10 at 13:10
code_cody97
749
Instead of printing result[0],result[1],result[2],first check the size of vector result and if it is '0' then return 0 or whatever is given and otherwise return result vector.
answered Nov 10 at 13:10
code_cody97
749
answered Nov 10 at 13:10
code_cody97
749
answered Nov 10 at 13:10
code_cody97
749
answered Nov 10 at 13:10
code_cody97
749
749
add a comment |
add a comment |
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53238679%2fcore-dumped-while-using-vectorstring%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
4
How is this function called?
– tkausl
Nov 10 at 11:58
What does your debugger say?
– melpomene
Nov 10 at 12:10
Welcome to SO, and congratulations on your first question. You may notice your question has been downvoted a few times, as it is not quite of the quality that gets great answers on here. You may find this guide helpful stackoverflow.com/help/how-to-ask.
– Tim Ogilvy
Nov 10 at 12:15
1
There's nothing obviously wrong with that, so the problem is probably in the surrounding code. Perhaps you're passing invalid vectors to it. You need to show how you're using the function. Read about what a Minimal, Complete, and Verifiable example is.
– molbdnilo
Nov 10 at 12:27
3
In this case an empty vector is returned. It probably crashes after the function returns, when you try to apply
to it.– HolyBlackCat
Nov 10 at 12:48