Is this express-session authentication method secure









up vote
0
down vote

favorite












Im not sure if this express-session auth method is secure. I encrypt the password using bcryptjs and after encrypting I set the req.session.isLoggedIn = true in admin.js and later check it in events.js by using an if statement. Is the if statement method in events.js secure or somehow breachable? Is there an better option?
I'm using handlebars to render the web pages.



admin.js



bcrypt.compare(pass, user.password).then((doMatch) => 
console.log(doMatch);
//Check if password match
if (doMatch)
//setting the isLoggedIn value
req.session.isLoggedIn = true;
//Events is the route that requires authentication
return res.redirect('/events');
else
res.redirect('/');

).catch((err) =>
console.log(err);
);


events.js



Router.get('/', (req, res) => 
//Checking the if the loggedIn value is true
if (req.session.isLoggedIn)
Event.find(, (err, events) =>
res.render('events',
prods: events,
pageTitle: 'Events',
path: '/events',
hasProducts: events.length > 0
);
).catch((err) =>
console.log(err);
);
else
console.log('User not authenticated');
res.status(404).send(error: 'not authorized!');


);









share|improve this question

























    up vote
    0
    down vote

    favorite












    Im not sure if this express-session auth method is secure. I encrypt the password using bcryptjs and after encrypting I set the req.session.isLoggedIn = true in admin.js and later check it in events.js by using an if statement. Is the if statement method in events.js secure or somehow breachable? Is there an better option?
    I'm using handlebars to render the web pages.



    admin.js



    bcrypt.compare(pass, user.password).then((doMatch) => 
    console.log(doMatch);
    //Check if password match
    if (doMatch)
    //setting the isLoggedIn value
    req.session.isLoggedIn = true;
    //Events is the route that requires authentication
    return res.redirect('/events');
    else
    res.redirect('/');

    ).catch((err) =>
    console.log(err);
    );


    events.js



    Router.get('/', (req, res) => 
    //Checking the if the loggedIn value is true
    if (req.session.isLoggedIn)
    Event.find(, (err, events) =>
    res.render('events',
    prods: events,
    pageTitle: 'Events',
    path: '/events',
    hasProducts: events.length > 0
    );
    ).catch((err) =>
    console.log(err);
    );
    else
    console.log('User not authenticated');
    res.status(404).send(error: 'not authorized!');


    );









    share|improve this question























      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      Im not sure if this express-session auth method is secure. I encrypt the password using bcryptjs and after encrypting I set the req.session.isLoggedIn = true in admin.js and later check it in events.js by using an if statement. Is the if statement method in events.js secure or somehow breachable? Is there an better option?
      I'm using handlebars to render the web pages.



      admin.js



      bcrypt.compare(pass, user.password).then((doMatch) => 
      console.log(doMatch);
      //Check if password match
      if (doMatch)
      //setting the isLoggedIn value
      req.session.isLoggedIn = true;
      //Events is the route that requires authentication
      return res.redirect('/events');
      else
      res.redirect('/');

      ).catch((err) =>
      console.log(err);
      );


      events.js



      Router.get('/', (req, res) => 
      //Checking the if the loggedIn value is true
      if (req.session.isLoggedIn)
      Event.find(, (err, events) =>
      res.render('events',
      prods: events,
      pageTitle: 'Events',
      path: '/events',
      hasProducts: events.length > 0
      );
      ).catch((err) =>
      console.log(err);
      );
      else
      console.log('User not authenticated');
      res.status(404).send(error: 'not authorized!');


      );









      share|improve this question













      Im not sure if this express-session auth method is secure. I encrypt the password using bcryptjs and after encrypting I set the req.session.isLoggedIn = true in admin.js and later check it in events.js by using an if statement. Is the if statement method in events.js secure or somehow breachable? Is there an better option?
      I'm using handlebars to render the web pages.



      admin.js



      bcrypt.compare(pass, user.password).then((doMatch) => 
      console.log(doMatch);
      //Check if password match
      if (doMatch)
      //setting the isLoggedIn value
      req.session.isLoggedIn = true;
      //Events is the route that requires authentication
      return res.redirect('/events');
      else
      res.redirect('/');

      ).catch((err) =>
      console.log(err);
      );


      events.js



      Router.get('/', (req, res) => 
      //Checking the if the loggedIn value is true
      if (req.session.isLoggedIn)
      Event.find(, (err, events) =>
      res.render('events',
      prods: events,
      pageTitle: 'Events',
      path: '/events',
      hasProducts: events.length > 0
      );
      ).catch((err) =>
      console.log(err);
      );
      else
      console.log('User not authenticated');
      res.status(404).send(error: 'not authorized!');


      );






      node.js express authentication






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 10 at 12:58









      nodejs_ios

      134




      134






















          1 Answer
          1






          active

          oldest

          votes

















          up vote
          0
          down vote













          I don't think this is the best method you should take a look at : http://www.passportjs.org/



          They have a good documentation about authentication strategies and registration also many other methods(Facebook login, Twitter...) also there is many tutorials on how you can implement Passport.js



          Hope it helps you !






          share|improve this answer




















            Your Answer






            StackExchange.ifUsing("editor", function ()
            StackExchange.using("externalEditor", function ()
            StackExchange.using("snippets", function ()
            StackExchange.snippets.init();
            );
            );
            , "code-snippets");

            StackExchange.ready(function()
            var channelOptions =
            tags: "".split(" "),
            id: "1"
            ;
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function()
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled)
            StackExchange.using("snippets", function()
            createEditor();
            );

            else
            createEditor();

            );

            function createEditor()
            StackExchange.prepareEditor(
            heartbeatType: 'answer',
            convertImagesToLinks: true,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: 10,
            bindNavPrevention: true,
            postfix: "",
            imageUploader:
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            ,
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            );



            );













            draft saved

            draft discarded


















            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53239186%2fis-this-express-session-authentication-method-secure%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes








            up vote
            0
            down vote













            I don't think this is the best method you should take a look at : http://www.passportjs.org/



            They have a good documentation about authentication strategies and registration also many other methods(Facebook login, Twitter...) also there is many tutorials on how you can implement Passport.js



            Hope it helps you !






            share|improve this answer
























              up vote
              0
              down vote













              I don't think this is the best method you should take a look at : http://www.passportjs.org/



              They have a good documentation about authentication strategies and registration also many other methods(Facebook login, Twitter...) also there is many tutorials on how you can implement Passport.js



              Hope it helps you !






              share|improve this answer






















                up vote
                0
                down vote










                up vote
                0
                down vote









                I don't think this is the best method you should take a look at : http://www.passportjs.org/



                They have a good documentation about authentication strategies and registration also many other methods(Facebook login, Twitter...) also there is many tutorials on how you can implement Passport.js



                Hope it helps you !






                share|improve this answer












                I don't think this is the best method you should take a look at : http://www.passportjs.org/



                They have a good documentation about authentication strategies and registration also many other methods(Facebook login, Twitter...) also there is many tutorials on how you can implement Passport.js



                Hope it helps you !







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Nov 10 at 14:05









                shili.oussama

                13




                13



























                    draft saved

                    draft discarded
















































                    Thanks for contributing an answer to Stack Overflow!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid


                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.

                    To learn more, see our tips on writing great answers.





                    Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


                    Please pay close attention to the following guidance:


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid


                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.

                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function ()
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53239186%2fis-this-express-session-authentication-method-secure%23new-answer', 'question_page');

                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    Use pre created SQLite database for Android project in kotlin

                    Darth Vader #20

                    Ondo