Rails render buttons by really complex condition
My rails application members may have one of the two different roles: vip_lite and vip.
They can subscribe plan to renew their authorizing.
We also have four types plan: vip_lite/monthly, vip_lite/yearly, vip/monthly, vip/yearly.
A vip user might be subscribing one of the four plans, so does vip_lite.
Member with different roles and different plans can see different buttons in plan page(e.g. vip_lite and subscribing vip_lite/monthly member can see 'upgrade' button in vip plan page).
see the following sample code: (currently write in helper)
def plan_action_button(user)
if user.vip? && user.subscribing_plan?(:vip_lite, :monthly)
'button_a'
elsif user.vip? && user.subscribing_plan?(:vip_lite, :yearly)
'button_b'
elsif user.vip? && user.subscribing_plan?(:vip, :monthly)
'button_c'
elsif user.vip? && user.subscribing_plan?(:vip, :monthly)
'button_d'
elsif user.vip_lite? && user.subscribing_plan?(:vip, :monthly)
'button_e'
elsif user.vip_lite? && user.subscribing_plan?(:vip, :yearly)
'button_e'
... and so on...
end
end
So I have to deal with 2 * 4 = 8 conditions for each button in these pages. Is there a good pattern in rails for dealing with such case? Thanks
ruby-on-rails design-patterns
asked Nov 14 '18 at 17:24
洪梓凱洪梓凱
156
add a comment |
My rails application members may have one of the two different roles: vip_lite and vip.
They can subscribe plan to renew their authorizing.
We also have four types plan: vip_lite/monthly, vip_lite/yearly, vip/monthly, vip/yearly.
A vip user might be subscribing one of the four plans, so does vip_lite.
Member with different roles and different plans can see different buttons in plan page(e.g. vip_lite and subscribing vip_lite/monthly member can see 'upgrade' button in vip plan page).
see the following sample code: (currently write in helper)
def plan_action_button(user)
if user.vip? && user.subscribing_plan?(:vip_lite, :monthly)
'button_a'
elsif user.vip? && user.subscribing_plan?(:vip_lite, :yearly)
'button_b'
elsif user.vip? && user.subscribing_plan?(:vip, :monthly)
'button_c'
elsif user.vip? && user.subscribing_plan?(:vip, :monthly)
'button_d'
elsif user.vip_lite? && user.subscribing_plan?(:vip, :monthly)
'button_e'
elsif user.vip_lite? && user.subscribing_plan?(:vip, :yearly)
'button_e'
... and so on...
end
end
So I have to deal with 2 * 4 = 8 conditions for each button in these pages. Is there a good pattern in rails for dealing with such case? Thanks
ruby-on-rails design-patterns
asked Nov 14 '18 at 17:24
洪梓凱洪梓凱
156
add a comment |
My rails application members may have one of the two different roles: vip_lite and vip.
They can subscribe plan to renew their authorizing.
We also have four types plan: vip_lite/monthly, vip_lite/yearly, vip/monthly, vip/yearly.
A vip user might be subscribing one of the four plans, so does vip_lite.
Member with different roles and different plans can see different buttons in plan page(e.g. vip_lite and subscribing vip_lite/monthly member can see 'upgrade' button in vip plan page).
see the following sample code: (currently write in helper)
def plan_action_button(user)
if user.vip? && user.subscribing_plan?(:vip_lite, :monthly)
'button_a'
elsif user.vip? && user.subscribing_plan?(:vip_lite, :yearly)
'button_b'
elsif user.vip? && user.subscribing_plan?(:vip, :monthly)
'button_c'
elsif user.vip? && user.subscribing_plan?(:vip, :monthly)
'button_d'
elsif user.vip_lite? && user.subscribing_plan?(:vip, :monthly)
'button_e'
elsif user.vip_lite? && user.subscribing_plan?(:vip, :yearly)
'button_e'
... and so on...
end
end
So I have to deal with 2 * 4 = 8 conditions for each button in these pages. Is there a good pattern in rails for dealing with such case? Thanks
ruby-on-rails design-patterns
asked Nov 14 '18 at 17:24
洪梓凱洪梓凱
156
My rails application members may have one of the two different roles: vip_lite and vip.
They can subscribe plan to renew their authorizing.
We also have four types plan: vip_lite/monthly, vip_lite/yearly, vip/monthly, vip/yearly.
A vip user might be subscribing one of the four plans, so does vip_lite.
Member with different roles and different plans can see different buttons in plan page(e.g. vip_lite and subscribing vip_lite/monthly member can see 'upgrade' button in vip plan page).
see the following sample code: (currently write in helper)
def plan_action_button(user)
if user.vip? && user.subscribing_plan?(:vip_lite, :monthly)
'button_a'
elsif user.vip? && user.subscribing_plan?(:vip_lite, :yearly)
'button_b'
elsif user.vip? && user.subscribing_plan?(:vip, :monthly)
'button_c'
elsif user.vip? && user.subscribing_plan?(:vip, :monthly)
'button_d'
elsif user.vip_lite? && user.subscribing_plan?(:vip, :monthly)
'button_e'
elsif user.vip_lite? && user.subscribing_plan?(:vip, :yearly)
'button_e'
... and so on...
end
end
So I have to deal with 2 * 4 = 8 conditions for each button in these pages. Is there a good pattern in rails for dealing with such case? Thanks
ruby-on-rails design-patterns
ruby-on-rails design-patterns
asked Nov 14 '18 at 17:24
洪梓凱洪梓凱
156
asked Nov 14 '18 at 17:24
洪梓凱洪梓凱
156
edited Nov 15 '18 at 3:15
洪梓凱
asked Nov 14 '18 at 17:24
洪梓凱洪梓凱
156
asked Nov 14 '18 at 17:24
洪梓凱洪梓凱
156
asked Nov 14 '18 at 17:24
洪梓凱洪梓凱
156
156
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
There are some interesting patterns that you can use here. Let's see what's repeated the most: user.vip?
Let's start the method with a guard clause
def plan_action_button(user)
return 'whatever you need to return' unless user.vip?
if user.subscribing_plan?(:vip_lite, :monthly)
'button_a'
[...]
Then because there's a lot of combinaisons, it's hard to tell what changes and what remains the same for those buttons. Is it a I18n key? Is is the button tag with different links? Do you have access to those parts separately like user.plan_name and user.plan_frequency?
Answering those questions would help you a lot in seeing emerge a pattern.
answered Nov 14 '18 at 19:24
Sophie DézielSophie Déziel
404211
The subscribing_plan?(xxx) combined with use.vip? or user.vip_lite? returns different buttons, so set guard clause for only user.vip? can not reduce the complexity I think. I've updated my code sample for more detailed description.
– 洪梓凱
Nov 15 '18 at 3:20
add a comment |
Your Answer
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "1"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53305672%2frails-render-buttons-by-really-complex-condition%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
There are some interesting patterns that you can use here. Let's see what's repeated the most: user.vip?
Let's start the method with a guard clause
def plan_action_button(user)
return 'whatever you need to return' unless user.vip?
if user.subscribing_plan?(:vip_lite, :monthly)
'button_a'
[...]
Then because there's a lot of combinaisons, it's hard to tell what changes and what remains the same for those buttons. Is it a I18n key? Is is the button tag with different links? Do you have access to those parts separately like user.plan_name and user.plan_frequency?
Answering those questions would help you a lot in seeing emerge a pattern.
answered Nov 14 '18 at 19:24
Sophie DézielSophie Déziel
404211
The subscribing_plan?(xxx) combined with use.vip? or user.vip_lite? returns different buttons, so set guard clause for only user.vip? can not reduce the complexity I think. I've updated my code sample for more detailed description.
– 洪梓凱
Nov 15 '18 at 3:20
add a comment |
There are some interesting patterns that you can use here. Let's see what's repeated the most: user.vip?
Let's start the method with a guard clause
def plan_action_button(user)
return 'whatever you need to return' unless user.vip?
if user.subscribing_plan?(:vip_lite, :monthly)
'button_a'
[...]
Then because there's a lot of combinaisons, it's hard to tell what changes and what remains the same for those buttons. Is it a I18n key? Is is the button tag with different links? Do you have access to those parts separately like user.plan_name and user.plan_frequency?
Answering those questions would help you a lot in seeing emerge a pattern.
answered Nov 14 '18 at 19:24
Sophie DézielSophie Déziel
404211
The subscribing_plan?(xxx) combined with use.vip? or user.vip_lite? returns different buttons, so set guard clause for only user.vip? can not reduce the complexity I think. I've updated my code sample for more detailed description.
– 洪梓凱
Nov 15 '18 at 3:20
add a comment |
There are some interesting patterns that you can use here. Let's see what's repeated the most: user.vip?
Let's start the method with a guard clause
def plan_action_button(user)
return 'whatever you need to return' unless user.vip?
if user.subscribing_plan?(:vip_lite, :monthly)
'button_a'
[...]
Then because there's a lot of combinaisons, it's hard to tell what changes and what remains the same for those buttons. Is it a I18n key? Is is the button tag with different links? Do you have access to those parts separately like user.plan_name and user.plan_frequency?
Answering those questions would help you a lot in seeing emerge a pattern.
answered Nov 14 '18 at 19:24
Sophie DézielSophie Déziel
404211
There are some interesting patterns that you can use here. Let's see what's repeated the most: user.vip?
Let's start the method with a guard clause
def plan_action_button(user)
return 'whatever you need to return' unless user.vip?
if user.subscribing_plan?(:vip_lite, :monthly)
'button_a'
[...]
Then because there's a lot of combinaisons, it's hard to tell what changes and what remains the same for those buttons. Is it a I18n key? Is is the button tag with different links? Do you have access to those parts separately like user.plan_name and user.plan_frequency?
Answering those questions would help you a lot in seeing emerge a pattern.
answered Nov 14 '18 at 19:24
Sophie DézielSophie Déziel
404211
answered Nov 14 '18 at 19:24
Sophie DézielSophie Déziel
404211
answered Nov 14 '18 at 19:24
Sophie DézielSophie Déziel
404211
answered Nov 14 '18 at 19:24
Sophie DézielSophie Déziel
404211
404211
The subscribing_plan?(xxx) combined with use.vip? or user.vip_lite? returns different buttons, so set guard clause for only user.vip? can not reduce the complexity I think. I've updated my code sample for more detailed description.
– 洪梓凱
Nov 15 '18 at 3:20
add a comment |
The subscribing_plan?(xxx) combined with use.vip? or user.vip_lite? returns different buttons, so set guard clause for only user.vip? can not reduce the complexity I think. I've updated my code sample for more detailed description.
– 洪梓凱
Nov 15 '18 at 3:20
The subscribing_plan?(xxx) combined with use.vip? or user.vip_lite? returns different buttons, so set guard clause for only user.vip? can not reduce the complexity I think. I've updated my code sample for more detailed description.
– 洪梓凱
Nov 15 '18 at 3:20
The subscribing_plan?(xxx) combined with use.vip? or user.vip_lite? returns different buttons, so set guard clause for only user.vip? can not reduce the complexity I think. I've updated my code sample for more detailed description.
– 洪梓凱
Nov 15 '18 at 3:20
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53305672%2frails-render-buttons-by-really-complex-condition%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
