Missing test case for linked list
0
I am writing a function to delete a give number from a linked list in codefights. I am passing 6 out of 7 test cases, however, the 7th is hidden so I am not able to see what it is I am doing wrong. Can anyone see what test case I am missing with this function?
// Definition for singly-linked list:
// template<typename T>
// struct ListNode
// ListNode(const T &v) : value(v), next(nullptr)
// T value;
// ListNode *next;
// ;
#include <stdio.h>
ListNode<int> * removeKFromList(ListNode<int> * l, int k)
ListNode<int> *cur = l;
ListNode<int> *temp = l;
while (cur != NULL)
if (cur->value == k)
if (cur == l)
ListNode<int> *del;
del = cur;
cur = cur->next;
l = l->next;
temp = temp->next;
delete del;
else
ListNode<int> *del = cur;
cur = cur->next;
temp->next = cur;
delete del;
else
temp = cur;
cur = cur->next;
return l;
c++ linked-list
edited Nov 11 at 13:22
AS Mackay
1,8654816
asked Nov 11 at 11:12
David Hafen
1
add a comment |
0
I am writing a function to delete a give number from a linked list in codefights. I am passing 6 out of 7 test cases, however, the 7th is hidden so I am not able to see what it is I am doing wrong. Can anyone see what test case I am missing with this function?
// Definition for singly-linked list:
// template<typename T>
// struct ListNode
// ListNode(const T &v) : value(v), next(nullptr)
// T value;
// ListNode *next;
// ;
#include <stdio.h>
ListNode<int> * removeKFromList(ListNode<int> * l, int k)
ListNode<int> *cur = l;
ListNode<int> *temp = l;
while (cur != NULL)
if (cur->value == k)
if (cur == l)
ListNode<int> *del;
del = cur;
cur = cur->next;
l = l->next;
temp = temp->next;
delete del;
else
ListNode<int> *del = cur;
cur = cur->next;
temp->next = cur;
delete del;
else
temp = cur;
cur = cur->next;
return l;
c++ linked-list
edited Nov 11 at 13:22
AS Mackay
1,8654816
asked Nov 11 at 11:12
David Hafen
1
2
Which programming language is this? Please tag your question appropriately. [c]?
– user202729
Nov 11 at 11:17
1
Please post a Minimal, Complete, and Verifiable example.
– melpomene
Nov 11 at 13:29
I don't know what you're doing wrong, but this code is overly complicated. It could be reduced toauto pp = &l; while (*pp) if ((*pp)->value == k) auto tmp = *pp; *pp = (*pp)->next; delete tmp; else pp = &(*pp)->next; return l;.
– melpomene
Nov 11 at 13:40
Code seems alright to me. Only issue I think is whether multiple deletes are needed in single query or not. If not then you are simply wasting the time iterating over the whole linked list
– Brij Raj Kishore
Nov 11 at 14:14
add a comment |
0
0
0
I am writing a function to delete a give number from a linked list in codefights. I am passing 6 out of 7 test cases, however, the 7th is hidden so I am not able to see what it is I am doing wrong. Can anyone see what test case I am missing with this function?
// Definition for singly-linked list:
// template<typename T>
// struct ListNode
// ListNode(const T &v) : value(v), next(nullptr)
// T value;
// ListNode *next;
// ;
#include <stdio.h>
ListNode<int> * removeKFromList(ListNode<int> * l, int k)
ListNode<int> *cur = l;
ListNode<int> *temp = l;
while (cur != NULL)
if (cur->value == k)
if (cur == l)
ListNode<int> *del;
del = cur;
cur = cur->next;
l = l->next;
temp = temp->next;
delete del;
else
ListNode<int> *del = cur;
cur = cur->next;
temp->next = cur;
delete del;
else
temp = cur;
cur = cur->next;
return l;
c++ linked-list
edited Nov 11 at 13:22
AS Mackay
1,8654816
asked Nov 11 at 11:12
David Hafen
1
I am writing a function to delete a give number from a linked list in codefights. I am passing 6 out of 7 test cases, however, the 7th is hidden so I am not able to see what it is I am doing wrong. Can anyone see what test case I am missing with this function?
// Definition for singly-linked list:
// template<typename T>
// struct ListNode
// ListNode(const T &v) : value(v), next(nullptr)
// T value;
// ListNode *next;
// ;
#include <stdio.h>
ListNode<int> * removeKFromList(ListNode<int> * l, int k)
ListNode<int> *cur = l;
ListNode<int> *temp = l;
while (cur != NULL)
if (cur->value == k)
if (cur == l)
ListNode<int> *del;
del = cur;
cur = cur->next;
l = l->next;
temp = temp->next;
delete del;
else
ListNode<int> *del = cur;
cur = cur->next;
temp->next = cur;
delete del;
else
temp = cur;
cur = cur->next;
return l;
c++ linked-list
c++ linked-list
edited Nov 11 at 13:22
AS Mackay
1,8654816
asked Nov 11 at 11:12
David Hafen
1
edited Nov 11 at 13:22
AS Mackay
1,8654816
asked Nov 11 at 11:12
David Hafen
1
edited Nov 11 at 13:22
AS Mackay
1,8654816
edited Nov 11 at 13:22
AS Mackay
1,8654816
edited Nov 11 at 13:22
AS Mackay
1,8654816
1,8654816
asked Nov 11 at 11:12
David Hafen
1
asked Nov 11 at 11:12
David Hafen
1
asked Nov 11 at 11:12
David Hafen
1
1
2
Which programming language is this? Please tag your question appropriately. [c]?
– user202729
Nov 11 at 11:17
1
Please post a Minimal, Complete, and Verifiable example.
– melpomene
Nov 11 at 13:29
I don't know what you're doing wrong, but this code is overly complicated. It could be reduced toauto pp = &l; while (*pp) if ((*pp)->value == k) auto tmp = *pp; *pp = (*pp)->next; delete tmp; else pp = &(*pp)->next; return l;.
– melpomene
Nov 11 at 13:40
Code seems alright to me. Only issue I think is whether multiple deletes are needed in single query or not. If not then you are simply wasting the time iterating over the whole linked list
– Brij Raj Kishore
Nov 11 at 14:14
add a comment |
2
Which programming language is this? Please tag your question appropriately. [c]?
– user202729
Nov 11 at 11:17
1
Please post a Minimal, Complete, and Verifiable example.
– melpomene
Nov 11 at 13:29
I don't know what you're doing wrong, but this code is overly complicated. It could be reduced toauto pp = &l; while (*pp) if ((*pp)->value == k) auto tmp = *pp; *pp = (*pp)->next; delete tmp; else pp = &(*pp)->next; return l;.
– melpomene
Nov 11 at 13:40
Code seems alright to me. Only issue I think is whether multiple deletes are needed in single query or not. If not then you are simply wasting the time iterating over the whole linked list
– Brij Raj Kishore
Nov 11 at 14:14
2
2
Which programming language is this? Please tag your question appropriately. [c]?
– user202729
Nov 11 at 11:17
Which programming language is this? Please tag your question appropriately. [c]?
– user202729
Nov 11 at 11:17
1
1
Please post a Minimal, Complete, and Verifiable example.
– melpomene
Nov 11 at 13:29
Please post a Minimal, Complete, and Verifiable example.
– melpomene
Nov 11 at 13:29
I don't know what you're doing wrong, but this code is overly complicated. It could be reduced to
auto pp = &l; while (*pp) if ((*pp)->value == k) auto tmp = *pp; *pp = (*pp)->next; delete tmp; else pp = &(*pp)->next; return l;.– melpomene
Nov 11 at 13:40
I don't know what you're doing wrong, but this code is overly complicated. It could be reduced to
auto pp = &l; while (*pp) if ((*pp)->value == k) auto tmp = *pp; *pp = (*pp)->next; delete tmp; else pp = &(*pp)->next; return l;.– melpomene
Nov 11 at 13:40
Code seems alright to me. Only issue I think is whether multiple deletes are needed in single query or not. If not then you are simply wasting the time iterating over the whole linked list
– Brij Raj Kishore
Nov 11 at 14:14
Code seems alright to me. Only issue I think is whether multiple deletes are needed in single query or not. If not then you are simply wasting the time iterating over the whole linked list
– Brij Raj Kishore
Nov 11 at 14:14
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "1"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53248140%2fmissing-test-case-for-linked-list%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53248140%2fmissing-test-case-for-linked-list%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
2
Which programming language is this? Please tag your question appropriately. [c]?
– user202729
Nov 11 at 11:17
1
Please post a Minimal, Complete, and Verifiable example.
– melpomene
Nov 11 at 13:29
I don't know what you're doing wrong, but this code is overly complicated. It could be reduced to
auto pp = &l; while (*pp) if ((*pp)->value == k) auto tmp = *pp; *pp = (*pp)->next; delete tmp; else pp = &(*pp)->next; return l;.– melpomene
Nov 11 at 13:40
Code seems alright to me. Only issue I think is whether multiple deletes are needed in single query or not. If not then you are simply wasting the time iterating over the whole linked list
– Brij Raj Kishore
Nov 11 at 14:14