Pfthb

Here is the c# code that controls an artillery shooting robot.

static bool ShouldFire(bool enemyInFront, string enemyName, int robotHealth)

 bool shouldFire = true;
 if (enemyInFront == true)
 
 if (enemyName == "boss")
 
 if (robotHealth < 50) shouldFire = false;
 if (robotHealth > 100) shouldFire = true;
 
 
 else
 
 return false;
 
 return shouldFire;

The code looks awkward somewhat and could be re-written significantly shorter. Can the community at stackoverflow suggest a c# method, that would do the same as in the code above, but using one operation? I kindly ask you to make your proposals. Here is some template of what one is looking for:

static bool ShouldFire2(bool enemyInFront, string enemyName, int robotHealth)

 return enemyInFront && (...);

I would appreciate some explanation, on how to achieve the desired outcome.

My suggestion is this:

static bool ShouldFire2(bool enemyInFront, string enemyName, int robotHealth)

 return enemyInFront && (enemyName == "boss" ? robotHealth >= 50 : true);

You first check in there is an enemy ahead. if yes, check if it is boss and if its hp greater than 50 then return true, otherwise false. If not a boss, always return true. And false if nothing in front of your character.

The line 'if (robotHealth > 100) shouldFire = true;' does nothing. shouldFire is already true unless health is under 50.

So you can reduce that section to:

static bool ShouldFire(bool enemyInFront, string enemyName, int robotHealth)

 bool shouldFire = true;
 if (enemyInFront == true)
 
 return !(enemyName != "boss" && robotHealth < 50); 
 else
 
 return false;
 
 return shouldFire;

Which could be reduced to:

static bool ShouldFire(bool enemyInFront, string enemyName, int robotHealth)

 return enemyInFront && (enemyName != "boss"