Pfthb

What the program does is allows the user to input a bunch of strings, stores them in a stack, and then outputs all of those strings in the stack but in reverse order and flipped. Is there a more efficient way of doing what I did? Maybe using a different data structure (other than a stack)? I though a stack would be best because the strings stored in the stacks need to be outputted in the opposite order that they were inputted.

Here's the code:

#include <iostream>
#include <stack>

using namespace std;

int main() 
 stack <string> elements;
 string element;

 cout << "Hello, welcome to Flippy-McBackwardson! nn" << endl;

 cout << "Please enter a bunch of strings (type END to terminate your list): " << endl;

 do 
 getline(cin, element);

 elements.push(element);
 while (element != "END");

 elements.pop();

 cout << "nFlippy Backward Version: " << endl;

 for (int x = elements.size()-1; x >= 0; x--)
 for (int i = elements.top().length()-1; i >= 0; i--)
 cout << elements.top()[i];
 
 elements.pop();
 cout << endl;
 

 return 0;

You can use reverse iterators (accessible using std::rbegin() and std::rend()) which should be cleaner and safer as they don't involve tricky subscripting math that is prone to off-by-one errors (at the very least).

while(!elements.empty())

 std::for_each(std::rbegin(elements.top()), std::rend(elements.top()),
 (char c) std::cout << c; );

 std::cout << 'n';

 elements.pop();