Pfthb

This is what I have in my text file.

6814,85,86,92,88
7234,76,81,84,78
6465,87,54,68,72
7899,92,90,88,86
9901,45,78,79,80
8234,77,87,84,98
7934,76,91,84,65
7284,56,81,87,98
7654,76,87,84,88
3534,86,81,84,73

And this is what I've coded.

void getName(float arr1[x][y])

 FILE* graFile;
 float arr2[x][y];
 char userIn[50];
 printf("Enter filename: ");
 scanf("%s", userIn);
 graFile = fopen(userIn, "r");
 int studentId, test1, test2, test3, test4;

 for(int i = 0; i < x; i++)
 
 for(int j = 0; j < y; j++)
 
 fscanf(graFile, "%d%d%d%d%d%f", &studentId, &test1, &test2, &test3, &test4, &arr2[i][j]);
 arr2[0][0] = studentId;
 arr2[0][1] = test1;
 arr2[0][2] = test2;
 arr2[0][3] = test3;
 arr2[0][4] = test4;
 
 
 for(int i = 0; i < x; i++)
 
 for(int j = 0; j < y; j++)
 
 printf("%f", arr2[i][j]);
 
 printf("n");
 
 fclose(graFile);
 return;

I have to write a program that asks the user to input the name of a text file (which contains grades), then load it into a 2D array. Then I have to sort the grades and take the average of the grades. I'm starting with my first function, which is to get the user input for a text file name and load it into a 2D array. I'm still new to C programming and I'm having a hard time understanding 2D arrays. I appreciate any help I can get.

the following proposed code:

1. cleanly compiles


2. performs the desired functionality


3. properly 'types' variables for the expected input


4. properly checks for errors


5. uses puts() when appropriate


6. properly outputs error messages to stderr
   


7. avoids unnecessary variable declarations and data copying


8. consistently indents the code


9. uses horizontal spacing, when appropriate, for readability


10. properly uses a format string in calls to printf()
    


11. separates code blocks: for if else while do...while switch case, default via a single blank line, for readability

and now, the proposed code:

#include <stdio.h>
#include <stdlib.h>

#define MAX_FILENAME_LEN 50

void getName( int x, int y )

 int arr2[x][y];
 char userIn[ MAX_FILENAME_LEN ];
 FILE* graFile;

 printf("%s", "Enter filename: ");
 if( scanf("%49s", userIn) != 1)
 
 fprintf( stderr, "scanf failed to read file namen" );
 exit( EXIT_FAILURE );
 

 // implied else, scanf successful

 graFile = fopen(userIn, "r");

 if( !graFile )
 
 perror( "fopen failed" );
 exit( EXIT_FAILURE );
 

 // implied else, fopen successful

 for(int i = 0; i < x; i++)
 
 if( fscanf( graFile, 
 "%d%d%d%d%d", 
 &arr2[i][0], 
 &arr2[i][1], 
 &arr2[i][2],
 &arr2[i][3],
 &arr2[i][4] ) != 5 )
 
 fclose( graFile );
 fprintf( stderr, "fscanf failed to read row %d from the input filen", i );
 exit( EXIT_FAILURE );
 
 

 fclose(graFile);

 for(int i = 0; i < x; i++)
 
 for(int j = 0; j < y; j++)
 
 printf("%d", arr2[i][j]);
 

 puts( "" );