Pfthb

I wrote a insertion sort program but it's not sorting the inputs correctly. Please help me find the error in the program.
If my input is 1 2 3 10 -1 -2 -3 then the output is

Value of a[0] is 1
Value of a[1] is 2
Value of a[2] is 3
Value of a[9] is -1
Value of a[10] is -2
Value of a[11] is -3
Value of a[19] is 10

I don't know if my logic is correct but I don't know where I did wrong please help me find the error in the program.

 #include<stdio.h>
void looper(int *);
void sort(int *,int *);
int main()

 int a[25];
 for(int i=0;i<=24;i++)
 
 printf("Enter the value of a[%d] : ",i);
 scanf("%d",&a[i]);
 
 looper(a);
 for(int i=0;i<=24;i++)
 
 printf("Value of a[%d] is %dn",i,a[i]);
 

void looper(int *p)

 for(int i=1;i<=24;i++)
 
 for(int j=(i-1);j>=0;j--)
 
 sort((p+i),(p+j));
 
 

void sort(int *a,int *b)

 int tmp;
 if((*a)<(*b))
 
 tmp=*a;
 *a=*b;
 *b=tmp;
 

Your current method is ... not quite right, for any kind of sort. Insertion sort would take an element and insert it at the correct index, then shift the already inserted items down appropriately. Something like

void looper(int *p)

 for (int i = 1;i < 25;i++)
 
 int key = p[i];
 int j = i - 1;
 while (j >= 0 && p[j] > key)
 
 p[j + 1] = p[j];
 j = j - 1;
 
 p[j + 1] = key;