Pfthb

Trying to save selected comboBox and textBox text to text file.
however there are multiple values being saved.

To avoid confusion systematically saving them on a specific line of the text file will help identify the values.

tried using the following, but application hangs.

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;
using System.IO;

namespace WindowsFormsApp1
{
 public partial class Setups : Form
 {
 public Setups()
 
 InitializeComponent();
 //this.TopMost = true;
 //this.FormBorderStyle = FormBorderStyle.None;
 //this.WindowState = FormWindowState.Maximized;

 
 private void textBox8_TextChanged(object sender, EventArgs e)
 

 
 private void comboBox1_SelectedIndexChanged(object sender, EventArgs e)
 



 

 static void lineChanger(string newText, string fileName, int line_to_edit)
 
 string arrLine = File.ReadAllLines(fileName);
 arrLine[line_to_edit - 1] = newText;
 File.WriteAllLines(fileName, arrLine);
 
 public void button5_Click(object sender, EventArgs e)
 1", comboBox1.Text, textBox8.Text), "sample.txt", 30); //


 // Succesfully wrote to file on first line
 //StreamWriter sw = new StreamWriter("Test.txt");

 //sw.WriteLine($"comboBox1.Text.textBox8.Text");
 //sw.Close();

 

A better solution would be to create a class that has all the settings and then serialize/deserialize it using JSON.

Use nuget to add the JSON package to your app. Example code to serialize: https://www.newtonsoft.com/json/help/html/SerializingJSON.htm

An application that hang and an out-of-range exception are 2 different things. Be precise in your question if you want help.

Also, your lineChanger function would obviously fails if the file you read does not already contains at least 30 lines when you click on button 5.

Hard coded number like that is always a bad idea in production code. If at some point, the file content is modified, it would be very hard to ensure that everything is properly fixed in the code.

If you really want to use such text file, then at the very least:

• use an enumeration or constants define a single place for the purpose of each line.


• use a class to manage your configuration so that only that class knows the structure of the file.

But as mentioned in another answer, it would be preferable to use another format like JSON. Almost every other format except binary data would be preferable to a text file (assuming that the content is settings for your application).

Having said that, if you really want lineChanger, then you should add a test like that:

if (line_to_edit >= arrLine.Length)

 List<string> list(arrLine);
 while (List.Length < line_to_edit) list.Add(string.Empty); 
 list.Add(newText);
 arrLine = list.ToArray();

else … old code from question… 

However, if you read other lines from the file or often read lines, it might become very slow to open/read/update/write/close the file each time a line is modified. Another reason why it would be a good idea to have a class to manage settings so that you load them once when opening the dialog and once when closing the dialog (assuming that the dialog is displayed a relatively short period of time and it is not critical to save changes immediately).

I think your question is too broad and needs more details.

You need to think of separating your form from your data. Create a data class to hold the values you want to be stored or read and have the UI interact with this class using data binding. Then your data class will always contain the most up-to-data information.

When needed, you can serialize your data file with TextStream, BinaryFormatter, XmlSerializer or JSON, depending on if the data needs to be accessed by other programs or locations. You can even use the built-in Settings to save the data before the application exits and to be read back in when it starts up again.

So please edit the question to clarify what you want to do with this data and add an example of what it looks like as a whole (all the lines in your text file now). Then we can answer more specifically.