What is the error in this time conversion code in Ruby?

up vote
-2
down vote

favorite

Question is to convert time in 12hour format into 24 hour format. Input is given as a single line string ( 12:45:00AM ===> 00:45:00 ).

def timeString(hh,mm,ss)
 hh.to_s.rjust(2,"0") + ":" + mm.to_s.rjust(2, "0") + ":" + ss.to_s.rjust(2, "0")
end

def timeConversion(s)
 hh = s[0,2].to_i
 mm = s[3,2].to_i
 ss = s[6,2].to_i

 if s[8]==?A
 if hh==12
 hh =0
 t =timeString(hh,mm,ss)
 return t
 elsif hh < 12
 t = timeString(hh,mm,ss)
 return t
 end 
 elsif s[8] == ?P
 if hh == 12
 t = timeString(hh,mm,ss)
 return t
 elsif hh >12
 hh -=12
 t = timeString(hh,mm,ss)
 return t
 end
 end 

end

s = gets.chomp 
result = timeConversion s 
print result

This code doesn't give an output. But, error cannot be seen

edited Nov 10 at 22:09

Holger Just

35.5k97999

asked Nov 10 at 21:00

Udith Indrakantha

The code works for me. Given the sample input of "12:45:00AM" it produces the desired output "00:45:00"
– showaltb
Nov 10 at 21:30

Thanks . I found the error. ' elsif hh >12 ' cannot be there. and hh-=12 is wrong.
– Udith Indrakantha
Nov 10 at 22:08

add a comment |

up vote
-2
down vote

favorite

Question is to convert time in 12hour format into 24 hour format. Input is given as a single line string ( 12:45:00AM ===> 00:45:00 ).

def timeString(hh,mm,ss)
 hh.to_s.rjust(2,"0") + ":" + mm.to_s.rjust(2, "0") + ":" + ss.to_s.rjust(2, "0")
end

def timeConversion(s)
 hh = s[0,2].to_i
 mm = s[3,2].to_i
 ss = s[6,2].to_i

 if s[8]==?A
 if hh==12
 hh =0
 t =timeString(hh,mm,ss)
 return t
 elsif hh < 12
 t = timeString(hh,mm,ss)
 return t
 end 
 elsif s[8] == ?P
 if hh == 12
 t = timeString(hh,mm,ss)
 return t
 elsif hh >12
 hh -=12
 t = timeString(hh,mm,ss)
 return t
 end
 end 

end

s = gets.chomp 
result = timeConversion s 
print result

This code doesn't give an output. But, error cannot be seen

edited Nov 10 at 22:09

Holger Just

35.5k97999

asked Nov 10 at 21:00

Udith Indrakantha

The code works for me. Given the sample input of "12:45:00AM" it produces the desired output "00:45:00"
– showaltb
Nov 10 at 21:30

Thanks . I found the error. ' elsif hh >12 ' cannot be there. and hh-=12 is wrong.
– Udith Indrakantha
Nov 10 at 22:08

add a comment |

up vote
-2
down vote

favorite

Question is to convert time in 12hour format into 24 hour format. Input is given as a single line string ( 12:45:00AM ===> 00:45:00 ).

def timeString(hh,mm,ss)
 hh.to_s.rjust(2,"0") + ":" + mm.to_s.rjust(2, "0") + ":" + ss.to_s.rjust(2, "0")
end

def timeConversion(s)
 hh = s[0,2].to_i
 mm = s[3,2].to_i
 ss = s[6,2].to_i

 if s[8]==?A
 if hh==12
 hh =0
 t =timeString(hh,mm,ss)
 return t
 elsif hh < 12
 t = timeString(hh,mm,ss)
 return t
 end 
 elsif s[8] == ?P
 if hh == 12
 t = timeString(hh,mm,ss)
 return t
 elsif hh >12
 hh -=12
 t = timeString(hh,mm,ss)
 return t
 end
 end 

end

s = gets.chomp 
result = timeConversion s 
print result

This code doesn't give an output. But, error cannot be seen

edited Nov 10 at 22:09

Holger Just

35.5k97999

asked Nov 10 at 21:00

Udith Indrakantha

Question is to convert time in 12hour format into 24 hour format. Input is given as a single line string ( 12:45:00AM ===> 00:45:00 ).

def timeString(hh,mm,ss)
 hh.to_s.rjust(2,"0") + ":" + mm.to_s.rjust(2, "0") + ":" + ss.to_s.rjust(2, "0")
end

def timeConversion(s)
 hh = s[0,2].to_i
 mm = s[3,2].to_i
 ss = s[6,2].to_i

 if s[8]==?A
 if hh==12
 hh =0
 t =timeString(hh,mm,ss)
 return t
 elsif hh < 12
 t = timeString(hh,mm,ss)
 return t
 end 
 elsif s[8] == ?P
 if hh == 12
 t = timeString(hh,mm,ss)
 return t
 elsif hh >12
 hh -=12
 t = timeString(hh,mm,ss)
 return t
 end
 end 

end

s = gets.chomp 
result = timeConversion s 
print result

This code doesn't give an output. But, error cannot be seen

ruby

edited Nov 10 at 22:09

Holger Just

35.5k97999

asked Nov 10 at 21:00

Udith Indrakantha

edited Nov 10 at 22:09

Holger Just

35.5k97999

asked Nov 10 at 21:00

Udith Indrakantha

edited Nov 10 at 22:09

Holger Just

35.5k97999

edited Nov 10 at 22:09

Holger Just

35.5k97999

edited Nov 10 at 22:09

Holger Just

35.5k97999

asked Nov 10 at 21:00

Udith Indrakantha

asked Nov 10 at 21:00

Udith Indrakantha

asked Nov 10 at 21:00

Udith Indrakantha

The code works for me. Given the sample input of "12:45:00AM" it produces the desired output "00:45:00"
– showaltb
Nov 10 at 21:30

Thanks . I found the error. ' elsif hh >12 ' cannot be there. and hh-=12 is wrong.
– Udith Indrakantha
Nov 10 at 22:08

add a comment |

The code works for me. Given the sample input of "12:45:00AM" it produces the desired output "00:45:00"
– showaltb
Nov 10 at 21:30

Thanks . I found the error. ' elsif hh >12 ' cannot be there. and hh-=12 is wrong.
– Udith Indrakantha
Nov 10 at 22:08

The code works for me. Given the sample input of "12:45:00AM" it produces the desired output "00:45:00"
– showaltb
Nov 10 at 21:30

Thanks . I found the error. ' elsif hh >12 ' cannot be there. and hh-=12 is wrong.
– Udith Indrakantha
Nov 10 at 22:08

add a comment |

1 Answer
1

active

oldest

votes

up vote
0
down vote

accepted

As you've found the problem I'll suggest an alternative way of writing your method.

def convert_12_to_24(s12)
 hr = s12[0,2].to_i
 hr = if s12[-2,2] == 'AM'
 hr == 12 ? 0 : hr
 else
 hr == 12 ? 12 : hr + 12
 end
 "%02d%s" % [hr, s12[2..-3]]
end

convert_12_to_24 "12:00:00AM" #=> "00:00:00"
convert_12_to_24 "12:59:59AM" #=> "00:59:59"
convert_12_to_24 "01:00:00AM" #=> "01:00:00"
convert_12_to_24 "11:59:00AM" #=> "11:59:00"
convert_12_to_24 "12:00:00PM" #=> "12:00:00"
convert_12_to_24 "12:59:59PM" #=> "12:59:59"
convert_12_to_24 "01:00:00PM" #=> "13:00:00"
convert_12_to_24 "11:59:59PM" #=> "23:59:59"

See Kernel#sprintf for string formatting directives (here "%02d%s").

answered Nov 11 at 6:46

Cary Swoveland

67.1k53865

add a comment |

Your Answer

StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");

StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "1"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);

else
createEditor();

);

function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);

);

draft saved

draft discarded

StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53243361%2fwhat-is-the-error-in-this-time-conversion-code-in-ruby%23new-answer', 'question_page');

);

Post as a guest

Name

Required, but never shown

1 Answer
1

active

oldest

votes

1 Answer
1

active

oldest

votes

up vote
0
down vote

accepted

As you've found the problem I'll suggest an alternative way of writing your method.

def convert_12_to_24(s12)
 hr = s12[0,2].to_i
 hr = if s12[-2,2] == 'AM'
 hr == 12 ? 0 : hr
 else
 hr == 12 ? 12 : hr + 12
 end
 "%02d%s" % [hr, s12[2..-3]]
end

convert_12_to_24 "12:00:00AM" #=> "00:00:00"
convert_12_to_24 "12:59:59AM" #=> "00:59:59"
convert_12_to_24 "01:00:00AM" #=> "01:00:00"
convert_12_to_24 "11:59:00AM" #=> "11:59:00"
convert_12_to_24 "12:00:00PM" #=> "12:00:00"
convert_12_to_24 "12:59:59PM" #=> "12:59:59"
convert_12_to_24 "01:00:00PM" #=> "13:00:00"
convert_12_to_24 "11:59:59PM" #=> "23:59:59"

See Kernel#sprintf for string formatting directives (here "%02d%s").

answered Nov 11 at 6:46

Cary Swoveland

67.1k53865

add a comment |

up vote
0
down vote

accepted

As you've found the problem I'll suggest an alternative way of writing your method.

def convert_12_to_24(s12)
 hr = s12[0,2].to_i
 hr = if s12[-2,2] == 'AM'
 hr == 12 ? 0 : hr
 else
 hr == 12 ? 12 : hr + 12
 end
 "%02d%s" % [hr, s12[2..-3]]
end

convert_12_to_24 "12:00:00AM" #=> "00:00:00"
convert_12_to_24 "12:59:59AM" #=> "00:59:59"
convert_12_to_24 "01:00:00AM" #=> "01:00:00"
convert_12_to_24 "11:59:00AM" #=> "11:59:00"
convert_12_to_24 "12:00:00PM" #=> "12:00:00"
convert_12_to_24 "12:59:59PM" #=> "12:59:59"
convert_12_to_24 "01:00:00PM" #=> "13:00:00"
convert_12_to_24 "11:59:59PM" #=> "23:59:59"

See Kernel#sprintf for string formatting directives (here "%02d%s").

answered Nov 11 at 6:46

Cary Swoveland

67.1k53865

add a comment |

up vote
0
down vote

accepted

As you've found the problem I'll suggest an alternative way of writing your method.

def convert_12_to_24(s12)
 hr = s12[0,2].to_i
 hr = if s12[-2,2] == 'AM'
 hr == 12 ? 0 : hr
 else
 hr == 12 ? 12 : hr + 12
 end
 "%02d%s" % [hr, s12[2..-3]]
end

convert_12_to_24 "12:00:00AM" #=> "00:00:00"
convert_12_to_24 "12:59:59AM" #=> "00:59:59"
convert_12_to_24 "01:00:00AM" #=> "01:00:00"
convert_12_to_24 "11:59:00AM" #=> "11:59:00"
convert_12_to_24 "12:00:00PM" #=> "12:00:00"
convert_12_to_24 "12:59:59PM" #=> "12:59:59"
convert_12_to_24 "01:00:00PM" #=> "13:00:00"
convert_12_to_24 "11:59:59PM" #=> "23:59:59"

See Kernel#sprintf for string formatting directives (here "%02d%s").

answered Nov 11 at 6:46

Cary Swoveland

67.1k53865

As you've found the problem I'll suggest an alternative way of writing your method.

def convert_12_to_24(s12)
 hr = s12[0,2].to_i
 hr = if s12[-2,2] == 'AM'
 hr == 12 ? 0 : hr
 else
 hr == 12 ? 12 : hr + 12
 end
 "%02d%s" % [hr, s12[2..-3]]
end

convert_12_to_24 "12:00:00AM" #=> "00:00:00"
convert_12_to_24 "12:59:59AM" #=> "00:59:59"
convert_12_to_24 "01:00:00AM" #=> "01:00:00"
convert_12_to_24 "11:59:00AM" #=> "11:59:00"
convert_12_to_24 "12:00:00PM" #=> "12:00:00"
convert_12_to_24 "12:59:59PM" #=> "12:59:59"
convert_12_to_24 "01:00:00PM" #=> "13:00:00"
convert_12_to_24 "11:59:59PM" #=> "23:59:59"

See Kernel#sprintf for string formatting directives (here "%02d%s").

answered Nov 11 at 6:46

Cary Swoveland

67.1k53865

answered Nov 11 at 6:46

Cary Swoveland

67.1k53865

answered Nov 11 at 6:46

Cary Swoveland

67.1k53865

answered Nov 11 at 6:46

Cary Swoveland

67.1k53865

add a comment |

draft saved

draft discarded

Thanks for contributing an answer to Stack Overflow!

Please be sure to answer the question. Provide details and share your research!

But avoid …

Asking for help, clarification, or responding to other answers.

Making statements based on opinion; back them up with references or personal experience.

To learn more, see our tips on writing great answers.

Some of your past answers have not been well-received, and you're in danger of being blocked from answering.

Please pay close attention to the following guidance:

Please be sure to answer the question. Provide details and share your research!

But avoid …

Asking for help, clarification, or responding to other answers.

Making statements based on opinion; back them up with references or personal experience.

To learn more, see our tips on writing great answers.

draft saved

draft discarded

Post as a guest

Name

Required, but never shown

Name

Required, but never shown

Name

Required, but never shown

This page is only for reference, If you need detailed information, please check here

搜尋此網誌

Pfthb