Pfthb

I am writing a batch script where I am writing a set of instruction inside function as I want to call it many time so want to reuse it.For me it works when i write outside function but inside function it never works . Below the code which I have used .

@echo off

set _prefs="%APPDATA%testtestBrowserProfileprefs.js"
set _prefs_notes="%ProgramFiles(x86)%testtset1DataworkspaceBrowserProfileprefs.js"

#rem it works
copy /y %_prefs_notes% %_prefs_notes%.copy1 > nul

CALL :AMEND_PREFJS %_prefs_notes%
EXIT /B 




:AMEND_PREFJS
rem make copy of prefs file
#rem it does not work
copy /y %~1 %~1.copy > nul
findstr /v "layers.acceleration.disabled" "%~1" > "%~1.tmp"
echo end

set %~1=
EXIT /B 0
goto end

:prefs_not_found
rem set error level?
echo "file does not exist -- %_prefs_notes%"

:end
set _prefs=

I am going to tell you what most of us do as best practices for writing batch files.

Never assign quotes to variables. You can use quotes though to protect the assignment of the variable. This helps with protecting special characters within the assignment and also keeps you from assigning trailing spaces.

Get into the habit of always using quotes to surround your file paths when using them with another command.

This is how I would write your batch file.

@echo off

set "_prefs=%APPDATA%testtestBrowserProfileprefs.js"
set "_prefs_notes=%ProgramFiles(x86)%testtset1DataworkspaceBrowserProfileprefs.js"

#rem it works
copy /y "%_prefs_notes%" "%_prefs_notes%.copy1" > nul

CALL :AMEND_PREFJS "%_prefs_notes%"
EXIT /B 

:AMEND_PREFJS
rem make copy of prefs file
#rem it does not work
copy /y "%~1" "%~1.copy" > nul
findstr /v "layers.acceleration.disabled" "%~1" > "%~1.tmp"
echo end
EXIT /B 0