What's the idiomatic way to convert a Result to a custom Fail impl?
up vote
0
down vote
favorite
Currently, I'm turning a Result
into an instance of my error enum that impls Fail
like this:
fn bbswitch_write(data: &str) -> Result<(), BbswitchError>
match fs::write("/proc/acpi/bbswitch", data)
Ok(_) => Ok(()),
Err(e) => Err(BbswitchError::BbswitchNotAvailable cause: e .into()),
but this feels very verbose, and I'd rather not write a four-line match
statement every time I do something like this:
let contents = fs::read_to_string("/proc/acpi/bbswitch").expect("bbswitch not available");
Is there something I'm doing wrong that's making error handling unreasonably difficult, or a way I could structure something better to make it more convenient?
The rest of my code looks something like this:
#[macro_use]
extern crate failure;
use std::fs;
use std::process::exit;
use failure::Error;
#[derive(Debug, Fail)]
enum BbswitchError
#[fail(display = "bbswitch not available")]
BbswitchNotAvailable
#[fail(cause)]
cause: std::io::Error,
,
fn bbswitch_write(data: &str) -> Result<(), Error>
match fs::write("/proc/acpi/bbswitch", data)
Ok(_) => Ok(()),
Err(e) => Err(BbswitchError::BbswitchNotAvailable cause: e .into()),
fn power_on() -> Result<(), Error>
bbswitch_write("ON")?;
Ok(())
fn main()
match power_on()
Ok(_) => ,
Err(_) => exit(1),
rust
add a comment |
up vote
0
down vote
favorite
Currently, I'm turning a Result
into an instance of my error enum that impls Fail
like this:
fn bbswitch_write(data: &str) -> Result<(), BbswitchError>
match fs::write("/proc/acpi/bbswitch", data)
Ok(_) => Ok(()),
Err(e) => Err(BbswitchError::BbswitchNotAvailable cause: e .into()),
but this feels very verbose, and I'd rather not write a four-line match
statement every time I do something like this:
let contents = fs::read_to_string("/proc/acpi/bbswitch").expect("bbswitch not available");
Is there something I'm doing wrong that's making error handling unreasonably difficult, or a way I could structure something better to make it more convenient?
The rest of my code looks something like this:
#[macro_use]
extern crate failure;
use std::fs;
use std::process::exit;
use failure::Error;
#[derive(Debug, Fail)]
enum BbswitchError
#[fail(display = "bbswitch not available")]
BbswitchNotAvailable
#[fail(cause)]
cause: std::io::Error,
,
fn bbswitch_write(data: &str) -> Result<(), Error>
match fs::write("/proc/acpi/bbswitch", data)
Ok(_) => Ok(()),
Err(e) => Err(BbswitchError::BbswitchNotAvailable cause: e .into()),
fn power_on() -> Result<(), Error>
bbswitch_write("ON")?;
Ok(())
fn main()
match power_on()
Ok(_) => ,
Err(_) => exit(1),
rust
add a comment |
up vote
0
down vote
favorite
up vote
0
down vote
favorite
Currently, I'm turning a Result
into an instance of my error enum that impls Fail
like this:
fn bbswitch_write(data: &str) -> Result<(), BbswitchError>
match fs::write("/proc/acpi/bbswitch", data)
Ok(_) => Ok(()),
Err(e) => Err(BbswitchError::BbswitchNotAvailable cause: e .into()),
but this feels very verbose, and I'd rather not write a four-line match
statement every time I do something like this:
let contents = fs::read_to_string("/proc/acpi/bbswitch").expect("bbswitch not available");
Is there something I'm doing wrong that's making error handling unreasonably difficult, or a way I could structure something better to make it more convenient?
The rest of my code looks something like this:
#[macro_use]
extern crate failure;
use std::fs;
use std::process::exit;
use failure::Error;
#[derive(Debug, Fail)]
enum BbswitchError
#[fail(display = "bbswitch not available")]
BbswitchNotAvailable
#[fail(cause)]
cause: std::io::Error,
,
fn bbswitch_write(data: &str) -> Result<(), Error>
match fs::write("/proc/acpi/bbswitch", data)
Ok(_) => Ok(()),
Err(e) => Err(BbswitchError::BbswitchNotAvailable cause: e .into()),
fn power_on() -> Result<(), Error>
bbswitch_write("ON")?;
Ok(())
fn main()
match power_on()
Ok(_) => ,
Err(_) => exit(1),
rust
Currently, I'm turning a Result
into an instance of my error enum that impls Fail
like this:
fn bbswitch_write(data: &str) -> Result<(), BbswitchError>
match fs::write("/proc/acpi/bbswitch", data)
Ok(_) => Ok(()),
Err(e) => Err(BbswitchError::BbswitchNotAvailable cause: e .into()),
but this feels very verbose, and I'd rather not write a four-line match
statement every time I do something like this:
let contents = fs::read_to_string("/proc/acpi/bbswitch").expect("bbswitch not available");
Is there something I'm doing wrong that's making error handling unreasonably difficult, or a way I could structure something better to make it more convenient?
The rest of my code looks something like this:
#[macro_use]
extern crate failure;
use std::fs;
use std::process::exit;
use failure::Error;
#[derive(Debug, Fail)]
enum BbswitchError
#[fail(display = "bbswitch not available")]
BbswitchNotAvailable
#[fail(cause)]
cause: std::io::Error,
,
fn bbswitch_write(data: &str) -> Result<(), Error>
match fs::write("/proc/acpi/bbswitch", data)
Ok(_) => Ok(()),
Err(e) => Err(BbswitchError::BbswitchNotAvailable cause: e .into()),
fn power_on() -> Result<(), Error>
bbswitch_write("ON")?;
Ok(())
fn main()
match power_on()
Ok(_) => ,
Err(_) => exit(1),
rust
rust
asked Nov 10 at 21:32
Josh
1,5631821
1,5631821
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
up vote
1
down vote
That very simple just use map_err()
:
fs::write("/proc/acpi/bbswitch", data)
.map_err(|e| BbswitchError::BbswitchNotAvailable cause: e .into())
add a comment |
Your Answer
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "1"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53243613%2fwhats-the-idiomatic-way-to-convert-a-result-to-a-custom-fail-impl%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
up vote
1
down vote
That very simple just use map_err()
:
fs::write("/proc/acpi/bbswitch", data)
.map_err(|e| BbswitchError::BbswitchNotAvailable cause: e .into())
add a comment |
up vote
1
down vote
That very simple just use map_err()
:
fs::write("/proc/acpi/bbswitch", data)
.map_err(|e| BbswitchError::BbswitchNotAvailable cause: e .into())
add a comment |
up vote
1
down vote
up vote
1
down vote
That very simple just use map_err()
:
fs::write("/proc/acpi/bbswitch", data)
.map_err(|e| BbswitchError::BbswitchNotAvailable cause: e .into())
That very simple just use map_err()
:
fs::write("/proc/acpi/bbswitch", data)
.map_err(|e| BbswitchError::BbswitchNotAvailable cause: e .into())
answered Nov 11 at 11:53
Stargateur
8,01641846
8,01641846
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53243613%2fwhats-the-idiomatic-way-to-convert-a-result-to-a-custom-fail-impl%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown