Pfthb

What's Happening:

The list (RecyclerView) is mixing up the data when I scroll.

I.E when I scroll back up after scrolling down, some of the list items are repeated, not displaying proper content.

package jamesnguyen.newzyv2.UI_update;

import android.content.Context;
import android.support.v7.widget.CardView;
import android.support.v7.widget.RecyclerView;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
import android.widget.TextView;

import java.util.List;

import jamesnguyen.newzyv2.R;
import jamesnguyen.newzyv2.RSS_Processcors.RssItem;

public class RVAdapter extends RecyclerView.Adapter<RVAdapter.FeedViewHolder> 

 private static List<RssItem> items = null;
 private static Context context;

 public RVAdapter(Context context, List<RssItem> items) 
 this.items = items;
 this.context = context;
 

 public static List<RssItem> getItems() 
 return items;
 

 @Override
 public RVAdapter.FeedViewHolder onCreateViewHolder(ViewGroup viewGroup, int i) 
 View v = LayoutInflater.from(viewGroup.getContext()).inflate(R.layout.item, viewGroup, false);
 return new FeedViewHolder(v);
 

 @Override
 public void onBindViewHolder(RVAdapter.FeedViewHolder holder, int position) 
 FeedViewHolder.getTitle().setText(items.get(position).getTitle());
 FeedViewHolder.getPubDate().setText(items.get(position).getPubDate());
 //FeedViewHolder.getDescription().setText(items.get(position).getDescription());
 

 @Override
 public long getItemId(int id) 
 return id;
 

 @Override
 public int getItemCount() 
 return items.size();
 

 @Override
 public void onAttachedToRecyclerView(RecyclerView recyclerView) 
 super.onAttachedToRecyclerView(recyclerView);
 

 public static class FeedViewHolder extends RecyclerView.ViewHolder 
 private static CardView cv;
 private static TextView title;
 private static TextView pubDate;
 private static TextView description;

 FeedViewHolder(View itemView) 
 super(itemView);
 cv = (CardView) itemView.findViewById(R.id.cv);
 title = (TextView) itemView.findViewById(R.id.title);
 pubDate = (TextView) itemView.findViewById(R.id.pubDate);
 //description = (TextView) itemView.findViewById(R.id.description);
 

 public static TextView getTitle() 
 return title;
 

 public static TextView getPubDate() 
 return pubDate;
 

 public static TextView getDescription() 
 return description;
 
 

I believe maybe some works have to be done with the recycling process of RecyclerView but nothing i tried seesm to work.

Only two things in your RecyclerView adapter

 @Override
public long getItemId(int position) 
 return position;

and in constructor of adapter

 setHasStableIds(true);

Hope it helps!

done .

@Override
public long getItemId(int position) 
 return position;


@Override
public int getItemViewType(int position) 
 return position;

Override these methods in your Adapter class like this.

@Override
public long getItemId(int position) 
 return position;


@Override
public int getItemViewType(int position) 
 return position;

The problem is the CardView and TextView objects are declared static inside the FeedViewHolder. That means that all the calls trying to set the title in the onBindViewHolder method hit the latest inflated View.

The fix is to remove the static from cv, title, pubDate, description, then implement some non static setters like:

public void setTitle(String s) 
 title.setText(s);

To be called in the onBindViewHolder method:

@Override
public void onBindViewHolder(RVAdapter.FeedViewHolder holder, int position) 
 holder.setTitle(items.get(position).getTitle());
 //...

In kotlin with clearing the previous items from the LinearLayout list item from the RecyclerView

override fun onBindViewHolder(view: MyViewHolder, index: Int) 
 view.guideLinearLayout.removeAllViews()
/* do binding here*/


override fun getItemId(position: Int): Long 
 return position.toLong()


override fun getItemViewType(position: Int): Int 
 return position