Beginner in R : writing my first function work only for one variable
up vote
-4
down vote
favorite
I am a beginner in R. I am actually trying to code my first function.
I am looking for csv files in a directory on my computer, then I put them into a data frame and then I am asking for the mean of some variable.
I have 2 variable : sulfate and nitrate.
My function works fine for nitrate but not for sulfate. I really don't know what is wrong. R studio gave me a clue : In mean.default(directory$suftate, na.rm = TRUE) :
argument is not numeric or logical: returning NA
But I don't know what to do with this information.
My function is :
pollutantmean <- function (directory, polluant = "nitrate", id = 1:332)
directory <- data.frame()
for (i in id)
directory <- rbind(directory, read.csv(full_files[i]))
if (polluant == "nitrate")
mean(directory$nitrate,na.rm = TRUE)
else if (polluant == "sulfate")
mean(directory$suftate,na.rm = TRUE)
else print("KO")
}
Can you help me ?
Caroline
r function if-statement numeric
add a comment |
up vote
-4
down vote
favorite
I am a beginner in R. I am actually trying to code my first function.
I am looking for csv files in a directory on my computer, then I put them into a data frame and then I am asking for the mean of some variable.
I have 2 variable : sulfate and nitrate.
My function works fine for nitrate but not for sulfate. I really don't know what is wrong. R studio gave me a clue : In mean.default(directory$suftate, na.rm = TRUE) :
argument is not numeric or logical: returning NA
But I don't know what to do with this information.
My function is :
pollutantmean <- function (directory, polluant = "nitrate", id = 1:332)
directory <- data.frame()
for (i in id)
directory <- rbind(directory, read.csv(full_files[i]))
if (polluant == "nitrate")
mean(directory$nitrate,na.rm = TRUE)
else if (polluant == "sulfate")
mean(directory$suftate,na.rm = TRUE)
else print("KO")
}
Can you help me ?
Caroline
r function if-statement numeric
2
Did you search for an answer? This Coursera topic has 136 reaults on SO already
– Rich Scriven
Nov 10 at 18:10
Hello Caroline. This is a homework assignment, and per the Coursera Honor Code you're not allowed to post complete answers to homework assignments on the internet.
– Len Greski
Nov 11 at 23:57
Hi @LenGreski, it's not totally the answer... it's not working! And the teacher encourage you to ask for help ;)
– Caroline Dobozy
Nov 12 at 9:30
The Coursera Honor Code specifically states, "You may not share your solutions to homework, quizzes, or exams with anyone else unless explicitly permitted by the instructor." In the JHU curriculum, some assignments (e.g. those students must post to GitHub or RPubs) have explicit permission to be shared. When a student has a problem s/he is allowed to post some code, but not an entire answer, regardless of whether the code is working. I recognize the Coursera policy is in conflict with the SO definition of a good question.
– Len Greski
Nov 18 at 21:48
add a comment |
up vote
-4
down vote
favorite
up vote
-4
down vote
favorite
I am a beginner in R. I am actually trying to code my first function.
I am looking for csv files in a directory on my computer, then I put them into a data frame and then I am asking for the mean of some variable.
I have 2 variable : sulfate and nitrate.
My function works fine for nitrate but not for sulfate. I really don't know what is wrong. R studio gave me a clue : In mean.default(directory$suftate, na.rm = TRUE) :
argument is not numeric or logical: returning NA
But I don't know what to do with this information.
My function is :
pollutantmean <- function (directory, polluant = "nitrate", id = 1:332)
directory <- data.frame()
for (i in id)
directory <- rbind(directory, read.csv(full_files[i]))
if (polluant == "nitrate")
mean(directory$nitrate,na.rm = TRUE)
else if (polluant == "sulfate")
mean(directory$suftate,na.rm = TRUE)
else print("KO")
}
Can you help me ?
Caroline
r function if-statement numeric
I am a beginner in R. I am actually trying to code my first function.
I am looking for csv files in a directory on my computer, then I put them into a data frame and then I am asking for the mean of some variable.
I have 2 variable : sulfate and nitrate.
My function works fine for nitrate but not for sulfate. I really don't know what is wrong. R studio gave me a clue : In mean.default(directory$suftate, na.rm = TRUE) :
argument is not numeric or logical: returning NA
But I don't know what to do with this information.
My function is :
pollutantmean <- function (directory, polluant = "nitrate", id = 1:332)
directory <- data.frame()
for (i in id)
directory <- rbind(directory, read.csv(full_files[i]))
if (polluant == "nitrate")
mean(directory$nitrate,na.rm = TRUE)
else if (polluant == "sulfate")
mean(directory$suftate,na.rm = TRUE)
else print("KO")
}
Can you help me ?
Caroline
r function if-statement numeric
r function if-statement numeric
edited Nov 10 at 18:08
marc_s
568k12810991249
568k12810991249
asked Nov 10 at 18:06
Caroline Dobozy
1
1
2
Did you search for an answer? This Coursera topic has 136 reaults on SO already
– Rich Scriven
Nov 10 at 18:10
Hello Caroline. This is a homework assignment, and per the Coursera Honor Code you're not allowed to post complete answers to homework assignments on the internet.
– Len Greski
Nov 11 at 23:57
Hi @LenGreski, it's not totally the answer... it's not working! And the teacher encourage you to ask for help ;)
– Caroline Dobozy
Nov 12 at 9:30
The Coursera Honor Code specifically states, "You may not share your solutions to homework, quizzes, or exams with anyone else unless explicitly permitted by the instructor." In the JHU curriculum, some assignments (e.g. those students must post to GitHub or RPubs) have explicit permission to be shared. When a student has a problem s/he is allowed to post some code, but not an entire answer, regardless of whether the code is working. I recognize the Coursera policy is in conflict with the SO definition of a good question.
– Len Greski
Nov 18 at 21:48
add a comment |
2
Did you search for an answer? This Coursera topic has 136 reaults on SO already
– Rich Scriven
Nov 10 at 18:10
Hello Caroline. This is a homework assignment, and per the Coursera Honor Code you're not allowed to post complete answers to homework assignments on the internet.
– Len Greski
Nov 11 at 23:57
Hi @LenGreski, it's not totally the answer... it's not working! And the teacher encourage you to ask for help ;)
– Caroline Dobozy
Nov 12 at 9:30
The Coursera Honor Code specifically states, "You may not share your solutions to homework, quizzes, or exams with anyone else unless explicitly permitted by the instructor." In the JHU curriculum, some assignments (e.g. those students must post to GitHub or RPubs) have explicit permission to be shared. When a student has a problem s/he is allowed to post some code, but not an entire answer, regardless of whether the code is working. I recognize the Coursera policy is in conflict with the SO definition of a good question.
– Len Greski
Nov 18 at 21:48
2
2
Did you search for an answer? This Coursera topic has 136 reaults on SO already
– Rich Scriven
Nov 10 at 18:10
Did you search for an answer? This Coursera topic has 136 reaults on SO already
– Rich Scriven
Nov 10 at 18:10
Hello Caroline. This is a homework assignment, and per the Coursera Honor Code you're not allowed to post complete answers to homework assignments on the internet.
– Len Greski
Nov 11 at 23:57
Hello Caroline. This is a homework assignment, and per the Coursera Honor Code you're not allowed to post complete answers to homework assignments on the internet.
– Len Greski
Nov 11 at 23:57
Hi @LenGreski, it's not totally the answer... it's not working! And the teacher encourage you to ask for help ;)
– Caroline Dobozy
Nov 12 at 9:30
Hi @LenGreski, it's not totally the answer... it's not working! And the teacher encourage you to ask for help ;)
– Caroline Dobozy
Nov 12 at 9:30
The Coursera Honor Code specifically states, "You may not share your solutions to homework, quizzes, or exams with anyone else unless explicitly permitted by the instructor." In the JHU curriculum, some assignments (e.g. those students must post to GitHub or RPubs) have explicit permission to be shared. When a student has a problem s/he is allowed to post some code, but not an entire answer, regardless of whether the code is working. I recognize the Coursera policy is in conflict with the SO definition of a good question.
– Len Greski
Nov 18 at 21:48
The Coursera Honor Code specifically states, "You may not share your solutions to homework, quizzes, or exams with anyone else unless explicitly permitted by the instructor." In the JHU curriculum, some assignments (e.g. those students must post to GitHub or RPubs) have explicit permission to be shared. When a student has a problem s/he is allowed to post some code, but not an entire answer, regardless of whether the code is working. I recognize the Coursera policy is in conflict with the SO definition of a good question.
– Len Greski
Nov 18 at 21:48
add a comment |
1 Answer
1
active
oldest
votes
up vote
0
down vote
- An opening curly brace is missing in the very first line
- This function will only work if there exists a global variable called
full_files
; consider passing it to
the function explicitly - Likely a typo in the
else if
clause:directory$sulfate
, notdirectory$suftate
- This function does not return anything; executing it won't actually do anything. Well, technically,
runningmean()
prints some output, but it may not always be the case, especially when run from the
command line, or when called from another function or script. Consider wrappingmean()
inprint()
(or, even better,return
ing it, which will allow you to assign the mean to other variables)
Thank you so much for your help ! I really wanted to do it myself :) without copy another function. However I am so sorry because, I haven't see the wrong speeling. It's now ok. Thanks !
– Caroline Dobozy
Nov 11 at 15:04
add a comment |
Your Answer
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "1"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53241924%2fbeginner-in-r-writing-my-first-function-work-only-for-one-variable%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
up vote
0
down vote
- An opening curly brace is missing in the very first line
- This function will only work if there exists a global variable called
full_files
; consider passing it to
the function explicitly - Likely a typo in the
else if
clause:directory$sulfate
, notdirectory$suftate
- This function does not return anything; executing it won't actually do anything. Well, technically,
runningmean()
prints some output, but it may not always be the case, especially when run from the
command line, or when called from another function or script. Consider wrappingmean()
inprint()
(or, even better,return
ing it, which will allow you to assign the mean to other variables)
Thank you so much for your help ! I really wanted to do it myself :) without copy another function. However I am so sorry because, I haven't see the wrong speeling. It's now ok. Thanks !
– Caroline Dobozy
Nov 11 at 15:04
add a comment |
up vote
0
down vote
- An opening curly brace is missing in the very first line
- This function will only work if there exists a global variable called
full_files
; consider passing it to
the function explicitly - Likely a typo in the
else if
clause:directory$sulfate
, notdirectory$suftate
- This function does not return anything; executing it won't actually do anything. Well, technically,
runningmean()
prints some output, but it may not always be the case, especially when run from the
command line, or when called from another function or script. Consider wrappingmean()
inprint()
(or, even better,return
ing it, which will allow you to assign the mean to other variables)
Thank you so much for your help ! I really wanted to do it myself :) without copy another function. However I am so sorry because, I haven't see the wrong speeling. It's now ok. Thanks !
– Caroline Dobozy
Nov 11 at 15:04
add a comment |
up vote
0
down vote
up vote
0
down vote
- An opening curly brace is missing in the very first line
- This function will only work if there exists a global variable called
full_files
; consider passing it to
the function explicitly - Likely a typo in the
else if
clause:directory$sulfate
, notdirectory$suftate
- This function does not return anything; executing it won't actually do anything. Well, technically,
runningmean()
prints some output, but it may not always be the case, especially when run from the
command line, or when called from another function or script. Consider wrappingmean()
inprint()
(or, even better,return
ing it, which will allow you to assign the mean to other variables)
- An opening curly brace is missing in the very first line
- This function will only work if there exists a global variable called
full_files
; consider passing it to
the function explicitly - Likely a typo in the
else if
clause:directory$sulfate
, notdirectory$suftate
- This function does not return anything; executing it won't actually do anything. Well, technically,
runningmean()
prints some output, but it may not always be the case, especially when run from the
command line, or when called from another function or script. Consider wrappingmean()
inprint()
(or, even better,return
ing it, which will allow you to assign the mean to other variables)
answered Nov 10 at 18:17
12b345b6b78
761115
761115
Thank you so much for your help ! I really wanted to do it myself :) without copy another function. However I am so sorry because, I haven't see the wrong speeling. It's now ok. Thanks !
– Caroline Dobozy
Nov 11 at 15:04
add a comment |
Thank you so much for your help ! I really wanted to do it myself :) without copy another function. However I am so sorry because, I haven't see the wrong speeling. It's now ok. Thanks !
– Caroline Dobozy
Nov 11 at 15:04
Thank you so much for your help ! I really wanted to do it myself :) without copy another function. However I am so sorry because, I haven't see the wrong speeling. It's now ok. Thanks !
– Caroline Dobozy
Nov 11 at 15:04
Thank you so much for your help ! I really wanted to do it myself :) without copy another function. However I am so sorry because, I haven't see the wrong speeling. It's now ok. Thanks !
– Caroline Dobozy
Nov 11 at 15:04
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53241924%2fbeginner-in-r-writing-my-first-function-work-only-for-one-variable%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
2
Did you search for an answer? This Coursera topic has 136 reaults on SO already
– Rich Scriven
Nov 10 at 18:10
Hello Caroline. This is a homework assignment, and per the Coursera Honor Code you're not allowed to post complete answers to homework assignments on the internet.
– Len Greski
Nov 11 at 23:57
Hi @LenGreski, it's not totally the answer... it's not working! And the teacher encourage you to ask for help ;)
– Caroline Dobozy
Nov 12 at 9:30
The Coursera Honor Code specifically states, "You may not share your solutions to homework, quizzes, or exams with anyone else unless explicitly permitted by the instructor." In the JHU curriculum, some assignments (e.g. those students must post to GitHub or RPubs) have explicit permission to be shared. When a student has a problem s/he is allowed to post some code, but not an entire answer, regardless of whether the code is working. I recognize the Coursera policy is in conflict with the SO definition of a good question.
– Len Greski
Nov 18 at 21:48