Pfthb

I have a file "Shalespeare_Hamlet.txt" and it contains

Hamlet, some text, Hamlet, SAMPLE TEXT.

A programm have to search the number of occurrences of words in the text.

How can i improve my code using strtok()?

using namespace std;
int main() 
const int len = 101;
char word[len], line[len];
cout << "Word: ";
cin >> word;

int l_word = strlen(word); 
ifstream fin("Shakespeare_Hamlet.txt"); 
if (!fin) 
 cout << "Error! Can't open the file.";
 system("pause");
 return 1;


int count = 0;
while (fin.getline(line, len)) 
 char *p = line; 
 while (p = strstr(p, word)) (*p == '')) count++;
 

cout << "Count of words: " << word << ": " << count << endl;
system("pause");

Thank you!

I completely redid the code hope that help

using namespace std;

int main() 
ifstream fin("Shakespeare_Hamlet.txt");
if (!fin) 
 cout << "Opening error!!!n";
 system("PAUSE");
 return EXIT_FAILURE;


fin.seekg(0, ios::end); 
long length = fin.tellg(); 
char *file = new char[length + 1];
fin.seekg(0, ios::beg); 
fin.read(file, length); 

int k = 0;
char* arr[50000];
char* str;
str = strtok(file, "n ,.-!?:;");

while (str != NULL) 
 arr[k] = str;
 k++;
 str = strtok(NULL, "n ,.-!?:;");


char word[20];
cout << "Enter word: ";
gets_s(word); 
int count = 0;
for (int i = 0; i < k; i++) 
 if (strcmp(arr[i], word) == 0) 
 count++;
 

cout << "Count of words: " << word << " : "<< count << endl;

delete file;
fin.close();
system("PAUSE");
return EXIT_SUCCESS;

You can't "improve" the program with strtok in C++ when there are better facilities like std::string and iostreams to solve the job.

Your code won't be working properly in several cases:

• If the searched word is in position in line which is split between two gets, for example the word "Hamlet" started in char position 98 in the line and split to "Ham" and "let".


• If there is punctuation in the beginning of the word, like "Hamlet... you only check the end of the string but not the beginning.

I think your algorithm should be as follows:

1. Read whole line into a std::string using std::getline
   


2. Remove all punctuation from the line,


3. Use std::istringstream to split line into words.


4. For each word check if equal to input word, and if so increment count.

For example:

std::string line;
//read whole line to std::string 
while (std::getline(fin, line)) 
 
 std::string result;
 //remove punctuation and copy to result
 std::remove_copy_if(line.begin(), line.end(), std::back_inserter(result), std::ptr_fun<int, int>(&std::ispunct) );
 //use string stream to parse line without punctuation 
 std::istringstream istr(result);
 std::string str;
 while(istr>>str)
 
 if(word==str)
 
 count++;